Skip to content

[SPARK-33304][R][SQL] Add from_avro and to_avro functions to SparkR #30216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zero323 wants to merge 7 commits into from
Closed

[SPARK-33304][R][SQL] Add from_avro and to_avro functions to SparkR #30216

zero323 wants to merge 7 commits into from

Conversation

@zero323
Copy link
Member

@zero323 zero323 commented Nov 1, 2020

What changes were proposed in this pull request?

Adds from_avro and to_avro functions to SparkR.

Why are the changes needed?

Feature parity.

Does this PR introduce any user-facing change?

New functions exposed in SparkR API.

How was this patch tested?

New unit tests.

@zero323 zero323 marked this pull request as draft November 1, 2020 17:46
@SparkQA
Copy link

SparkQA commented Nov 1, 2020

Test build #130499 has finished for PR 30216 at commit 6cde957.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 1, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35103/

@SparkQA
Copy link

SparkQA commented Nov 1, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35103/

@SparkQA
Copy link

SparkQA commented Nov 1, 2020

Test build #130504 has finished for PR 30216 at commit 1e9545f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 1, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35107/

@SparkQA
Copy link

SparkQA commented Nov 2, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35107/

HyukjinKwon
HyukjinKwon reviewed Nov 2, 2020
View reviewed changes
HyukjinKwon
HyukjinKwon reviewed Nov 2, 2020
View reviewed changes
@zero323
Copy link
Member Author

zero323 commented Nov 2, 2020

I am going to rebase it to master, to fix AppVeyor failure.

@SparkQA
Copy link

SparkQA commented Nov 2, 2020

Test build #130519 has finished for PR 30216 at commit c5e5186.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 2, 2020

Test build #130520 has finished for PR 30216 at commit 55c3780.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 2, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35119/

@SparkQA
Copy link

SparkQA commented Nov 2, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35120/

@SparkQA
Copy link

SparkQA commented Nov 2, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35119/

@zero323 zero323 marked this pull request as ready for review November 2, 2020 09:27
@SparkQA
Copy link

SparkQA commented Nov 2, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35120/

@SparkQA
Copy link

SparkQA commented Nov 2, 2020

Test build #130529 has finished for PR 30216 at commit 8bdf665.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 2, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35129/

@SparkQA
Copy link

SparkQA commented Nov 2, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35129/

@SparkQA
Copy link

SparkQA commented Nov 2, 2020

Test build #130530 has finished for PR 30216 at commit 1457133.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 2, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35130/

@SparkQA
Copy link

SparkQA commented Nov 2, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35130/

@SparkQA
Copy link

SparkQA commented Nov 2, 2020

Test build #130534 has finished for PR 30216 at commit 63f7792.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 2, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35134/

@SparkQA
Copy link

SparkQA commented Nov 2, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35134/

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Nov 6, 2020

Thank you, @zero323 .

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Nov 6, 2020

Retest this please.

@SparkQA
Copy link

SparkQA commented Nov 6, 2020

Test build #130736 has finished for PR 30216 at commit 63f7792.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 6, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35345/

@SparkQA
Copy link

SparkQA commented Nov 6, 2020

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35345/

@zero323 zero323 requested a review from HyukjinKwon November 19, 2020 00:25
@HyukjinKwon
Copy link
Member

HyukjinKwon commented Nov 19, 2020

Merged to master.

@zero323
Copy link
Member Author

zero323 commented Nov 19, 2020

Thanks @dongjoon-hyun @HyukjinKwon!

@zero323 zero323 deleted the SPARK-33304 branch November 19, 2020 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zero323 @SparkQA @dongjoon-hyun @HyukjinKwon